Fix GESTURE_DRAG and GESTURE_SWIPE_* issues (mostly) for web #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ubkp Thank you very much for all the amazing work put into improving the gestures module! Actually the review was int the list of future improvements for the library and you mostly did it all by yourself! Thanks! One detail, trying the example on Windows (with mouse), I notice that HOLD is always issued after just a TAP, shouldn't it take some time to be detected? |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a different check to detect
GESTURE_DRAGforPLATFORM_WEB.Adds a
DRAG_TIMEOUTdefine for the previous check.Adds
GESTURE_HOLDto the check to update theGESTURES.Touch.upPosition.Changes the default value of
FORCE_TO_SWIPEto make it less twitchy for high sensitivity web browsers like Chrome for Android.Fix #3182.